Skip to content

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Nov 3, 2025

Motivation

Status: testing perf

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Lines of code report

Total lines added: 0
Total lines removed: 40
Total lines changed: 40

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/trie_db/layering.rs | 144   | -40  |
+-------------------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 336.997 ± 0.515 336.315 337.832 2.51 ± 0.00
head 134.481 ± 0.128 134.226 134.685 1.00

@edg-l
Copy link
Contributor Author

edg-l commented Nov 5, 2025

The capacity needs to be really large, furthermore since the cuckoo is not Clone and also has no merge method, it requires cloning it when adding a filter and then again when rebuilding the bloom. Current benchmarks don't show it improve and i think its clear since too much work around it needs to be done for it to work.

@edg-l edg-l closed this Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Done in ethrex_l1 Nov 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in ethrex_performance Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client performance

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants